Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tolerations and nodeSelector to entire chart #4469

Open
jassherman opened this issue Jan 27, 2025 · 5 comments
Open

add tolerations and nodeSelector to entire chart #4469

jassherman opened this issue Jan 27, 2025 · 5 comments
Labels
type/enhancement New feature or request

Comments

@jassherman
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

We have taints on the specific cluster nodes and would like gossipEncryption to tolerate the nodes.

Feature Description

Use Case(s)

Adding tolerations and nodeSelector would allow for precise placement of the gossipEncryption pod.

Contributions

@jassherman jassherman added the type/enhancement New feature or request label Jan 27, 2025
@jassherman jassherman changed the title add tolerations and nodeSelector to gossipEncryption add tolerations and nodeSelector to entire chart Jan 27, 2025
@jassherman
Copy link
Author

Based on our configuration, we needed to add tolerations and nodeSelector to the following yamls:
gossip-encryption-autogenerate-job
tls-init-job
tls-init-cleanup-job

tls example
{{- if .Values.global.tls.tolerations }} tolerations: {{ tpl .Values.global.tls.tolerations . | indent 8 | trim }} {{- end }} {{- if .Values.global.tls.nodeSelector }} nodeSelector: {{ tpl .Values.global.tls.nodeSelector . | indent 8 | trim }} {{- end }}

@olegbzk
Copy link

olegbzk commented Feb 4, 2025

The same problem: consul-tls-init pod is stuck with an error

0/8 nodes are available: 1 node(s) had untolerated taint {CriticalAddonsOnly: true}, 
1 node(s) had untolerated taint {company.com/purpose: argocd}, 
1 node(s) had untolerated taint {company.com/purpose: infra}, 
1 node(s) had untolerated taint {company.com/purpose: kafka}, 
4 node(s) had untolerated taint {company.com/purpose: application}. 
preemption: 0/8 nodes are available: 
8 Preemption is not helpful for scheduling.

@jassherman
Copy link
Author

The toleration options are not available in the following yaml files, assuming you are using the helm chart.

gossip-encryption-autogenerate-job
tls-init-job
tls-init-cleanup-job

You need to edit each of these yaml files adding the code above in the correct format (the formatting is not correct above. Look at another yaml file for the correct formatting)

After you add the code to those three yamls, you need add the tolerations: and nodeSelector to the correct places in the values.yaml file.

@olegbzk
Copy link

olegbzk commented Feb 5, 2025

I'm using the chart directly from the Hashicorp repo; there is no chance to edit YAML. No tolerations and nodeSelector in the code of tls-init-job

@jassherman
Copy link
Author

I suggest you use helm pull to download the chart locally. Then you can update the yamls as describe above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants