Clarification - Node Identifiers - AccountId vs. EntityId vs. NodeId

[iamjpotts]

Problem

Currently, when creating a Client with a custom network (a custom mapping of node ids with host/port pairs) rather than one of the default networks (e.g. for mainnet or testnet), that mapping is defined as HashMap<String, AccountId> where the key is a host/port pair and the value is a node id.

Elsewhere in the crate, there is an EntityId type similar to AccountId but with different semantics. There is no NodeId type currently.

Is AccountId the appropriate type to model a node id, or should the existing EntityId or a new NodeId be used instead?

Solution

Refactor usages of this host to node map to have a different value type for the node other than AccountId.

Alternatives

• For node identifiers, in place of AccountId, use existing EntityId type
• For node identifiers, in place of AccountId, use a new NodeId type