You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ata-nas opened this issue
Oct 22, 2024
· 2 comments
· Fixed by #405
Assignees
Labels
BugA error that causes the feature to behave differently than what was expected based on design docsP2Required to be completed in the assigned milestone, but may or may not impact release schedule.SimulatorIssue related to Block Stream Simulator
Currently, there is some missing support for some configurable values via environment variables.
What should to happen
In order to support environment variables for configuration classes, we need to map the conventional screaming snake case for environment variables (since still by default we are not able to get another case at runtime) to a convention the config api understands(e.g. MEDIATOR_RING_BUFFER_SIZE to mediator.ringBufferSize). This is done by updating the com.hedera.block.server.config.ServerMappedConfigSourceInitializer#MAPPINGS and we also need to update the respective awareness test com.hedera.block.server.config.ServerMappedConfigSourceInitializerTest#SUPPORTED_MAPPINGS. Also, alongside that, we should update the README.md to let the users know what are the correct screaming snake case keys for the configs.
Tasklist
Update all the other needed configurations that need to be supported to be set via environment variables in :server
Update all the other needed configurations that need to be supported to be set via environment variables in :simulator
AlfredoG87
added
Simulator
Issue related to Block Stream Simulator
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
labels
Oct 22, 2024
@AlfredoG87 no, this should not be closed as it is not implemented/merged anywhere.
In the above description, it is given example of an already existing config in order to showcase what must be done to all the others that need to be supported via environment variables. This issue IS NOT about the example above, but for all the rest.
I am reopening this. I also add a couple of checkboxes to make it more clear.
jsync-swirlds
changed the title
bug: missing support for configuration through environment variables
chore: Add all newer configuration items to Environment Variable mapping.
Dec 11, 2024
BugA error that causes the feature to behave differently than what was expected based on design docsP2Required to be completed in the assigned milestone, but may or may not impact release schedule.SimulatorIssue related to Block Stream Simulator
Description
What happened
Currently, there is some missing support for some configurable values via environment variables.
What should to happen
In order to support environment variables for configuration classes, we need to map the conventional screaming snake case for environment variables (since still by default we are not able to get another case at runtime) to a convention the config api understands(e.g.
MEDIATOR_RING_BUFFER_SIZE
tomediator.ringBufferSize
). This is done by updating thecom.hedera.block.server.config.ServerMappedConfigSourceInitializer#MAPPINGS
and we also need to update the respective awareness testcom.hedera.block.server.config.ServerMappedConfigSourceInitializerTest#SUPPORTED_MAPPINGS
. Also, alongside that, we should update theREADME.md
to let the users know what are the correct screaming snake case keys for the configs.Tasklist
:server
:simulator
Missing configuration that should be added:
server
:simulator
:Version
0.2.0-SNAPSHOT
The text was updated successfully, but these errors were encountered: