From a754baf7425904249d2c883f86d52a62528a9680 Mon Sep 17 00:00:00 2001 From: Volker Theile Date: Tue, 26 Mar 2024 10:53:55 +0100 Subject: [PATCH] Bump golangci-lint + fix lint issues Signed-off-by: Volker Theile --- Dockerfile.dapper | 2 +- cmd/webhook/main.go | 2 +- main.go | 2 +- pkg/ksmtuned/ksmd.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Dockerfile.dapper b/Dockerfile.dapper index eb554c3b..34bac18b 100644 --- a/Dockerfile.dapper +++ b/Dockerfile.dapper @@ -7,7 +7,7 @@ RUN zypper -n rm container-suseconnect && \ zypper -n install git curl docker gzip tar wget awk ## install golangci -RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.55.2 +RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.57.1 ## install controller-gen RUN go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.6.2 diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index a352d539..0ce2b8c8 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -78,7 +78,7 @@ func main() { app := cli.NewApp() app.Flags = flags - app.Action = func(c *cli.Context) error { + app.Action = func(_ *cli.Context) error { setLogLevel(logLevel) err := runWebhookServer(ctx, cfg, &options) return err diff --git a/main.go b/main.go index d96d89a2..a530589f 100644 --- a/main.go +++ b/main.go @@ -94,7 +94,7 @@ func main() { }, } - app.Action = func(c *cli.Context) error { + app.Action = func(_ *cli.Context) error { initProfiling(&opt) initLogs(&opt) return run(&opt) diff --git a/pkg/ksmtuned/ksmd.go b/pkg/ksmtuned/ksmd.go index a17ea2a7..dcd10397 100644 --- a/pkg/ksmtuned/ksmd.go +++ b/pkg/ksmtuned/ksmd.go @@ -94,7 +94,7 @@ func (k *ksmd) toggleMergeAcrossNodes(ctx context.Context, toggle uint) (err err } ctxCancel, cancel := context.WithCancel(ctx) - wait.UntilWithContext(ctxCancel, func(ctx context.Context) { + wait.UntilWithContext(ctxCancel, func(_ context.Context) { var s *ksmdStatus s, err = k.readKsmdStatus() if err != nil || s.shared+s.sharing+s.unshared < 1 {