Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sync] fix a panic issue found in stream tests #3687

Merged
merged 1 commit into from
May 4, 2021
Merged

[sync] fix a panic issue found in stream tests #3687

merged 1 commit into from
May 4, 2021

Conversation

JackyWYX
Copy link
Contributor

@JackyWYX JackyWYX commented May 3, 2021

Issue

Fix #3685 of panic issue.

When user start node with dns server as false, node will panic and exit. The error is introduced in sync port fix.

Test:

Tested locally

@JackyWYX JackyWYX requested review from LeoHChen and sophoah May 3, 2021 18:44
@JackyWYX JackyWYX self-assigned this May 3, 2021
@JackyWYX JackyWYX mentioned this pull request May 3, 2021
Open
@LeoHChen LeoHChen merged commit d8b5d16 into harmony-one:main May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoHChen LeoHChen LeoHChen approved these changes

@sophoah sophoah Awaiting requested review from sophoah

Assignees

@JackyWYX JackyWYX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test and rollout stream syncing on mainnet
2 participants
@JackyWYX @LeoHChen