Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a dedicated "burn" button and/or function? #79

Open
ElliotFriend opened this issue Mar 8, 2023 · 1 comment
Open

Make a dedicated "burn" button and/or function? #79

ElliotFriend opened this issue Mar 8, 2023 · 1 comment

Comments

@ElliotFriend
Copy link

ElliotFriend commented Mar 8, 2023

Possible feature request

I've only seen this a couple times, so it probably belongs very low on the priority list. When trying to clean selected balances, I've seen transactions fail with responses like op_under_dest_min. I'm assuming that it has to do with not having enough liquidity on the DEX.

It would be cool to be able to specify that balance_3, balance_3 && balance_5, etc. should be burnt, instead of trying to clean it. I think the site has a feature that detects some cases like this (??), but it would be neat to have the ability to manually specify for those weird/tricky situations.

Just an idea. Feel free to ignore me 😁

@hanseartic
Copy link
Owner

hanseartic commented Mar 15, 2023

Thank you for the suggestion! In general the CBs are burnt, if there is either no path to swap them or if the yield is below the fees. Sometimes with low-liquid assets you'd get a quote on selecting the CB but by the time the transaction is executed that very offer has already been taken. That should be the only case you'd see a op_under_dest_min error. Simply retrying should give you a new quote and in such cases case probably resort to burning the claimed asset. If that subsequently fails you can also just claim the CB, afterwards go the account overview and burn from there.

But I will also look into how your suggestions can be introduced as it smoothens the UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants