Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package versioning #296

Open
azygis opened this issue Mar 10, 2023 · 4 comments
Open

Package versioning #296

azygis opened this issue Mar 10, 2023 · 4 comments

Comments

@azygis
Copy link
Collaborator

azygis commented Mar 10, 2023

          Just have an additional comment :) 

Maybe not the right thread, please tell me if I should ask (or read) it somewhere else.
How versions are organized in this package? How do you decide which version part to increase: major, minor or patch?

Originally posted by @mantasaudickas in #284 (comment)

@azygis
Copy link
Collaborator Author

azygis commented Mar 10, 2023

@frankhommers has the longest run with this package; I'm not yet sure how to bump the version with GitVersion.MSBuild. Good question and I would like to know as well since I'll create a GH action to publish the package to nuget soon.

@frankhommers
Copy link
Collaborator

I want to keep versioning with GitVersion.

As soon as you tag the image with Major.Minor.Revision, GitVersion.MSBuild will take that version.

For about every version I just bump the version by hand in the Revision tag. No extensive thoughts went into this.
But stamping with GitVersion I do want to keep. And I think we must adhere to SemVer also.

Do you know enough, or do we need to write some sort of policy for this?

@azygis
Copy link
Collaborator Author

azygis commented Mar 12, 2023

GitVersion is fine. I'm more about when to bump the minor version. Major is pretty clear, but lately regardless of bugfixes or a few small features here and there it's always just a patch version. I think the last version (which added long running polling) would have warranted the bump on minor version, since technically it is something new.

My plan is to add an action that publishes the NuGet package automatically after creating a release/tag. If I'm not mistaken, we can specify SemVer to the GitVersion task (I guess it's just MSBuild properties), but I did not investigate just yet.

@frankhommers
Copy link
Collaborator

Publishing on tagging is fine and the way to go if you ask me.

But yeah, you are right, we should bump minor versions on new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants