Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CODECOVE_TOKEN secret while uploading data to codecov #1467

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Use CODECOVE_TOKEN secret while uploading data to codecov #1467

merged 1 commit into from
Dec 3, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Dec 3, 2024 •
edited
Loading

Context

It fixes the "Rate limit reached" error in GH action.

How did you test your changes?

uploading data to codecov works with no errors (unit-tests action)

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation
  • Change in CI/CD tooling

Related issues:

  1. Fixes [Bug]: Codecov upload "Rate limit reached" error in GH action #1446

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Performance comparison of head (0ffb58d) vs base (5368e84)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 511.32 | 519.35 | +1.57%
                                      Sheet B | 166.57 |  168.6 | +1.22%
                                      Sheet T | 146.47 | 146.99 | +0.36%
                                Column ranges |  515.7 | 512.18 | -0.68%
Sheet A:  change value, add/remove row/column |  14.64 |  14.19 | -3.07%
 Sheet B: change value, add/remove row/column | 134.31 | 129.15 | -3.84%
                   Column ranges - add column | 151.17 | 154.76 | +2.37%
                Column ranges - without batch | 443.23 | 458.97 | +3.55%
                        Column ranges - batch | 109.99 | 118.24 | +7.50%

@sequba sequba linked an issue Dec 3, 2024 that may be closed by this pull request
[Bug]: Codecov upload "Rate limit reached" error in GH action #1446
Open
@sequba sequba merged commit fa06221 into develop Dec 3, 2024
22 of 24 checks passed
@sequba sequba deleted the feature/issue-1446 branch December 3, 2024 15:46
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (a91f5d7) to head (0ffb58d).
Report is 22 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1467      +/-   ##
===========================================
- Coverage    97.22%   97.20%   -0.02%     
===========================================
  Files          169      169              
  Lines        14430    14430              
  Branches      3101     3027      -74     
===========================================
- Hits         14029    14027       -2     
- Misses         401      403       +2

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Codecov upload "Rate limit reached" error in GH action
1 participant
@sequba