#error "buffer_larger_than_two_gigs requires assertions"

[LebedevRI]

https://github.com/halide/Halide/blob/release/19.x/test/error/buffer_larger_than_two_gigs.cpp#L4-L6
is that actually nessesary/correct especially given
https://github.com/halide/Halide/blob/release/19.x/src/Buffer.h#L142-L148
?

Though src/LLVM_Headers.h / src/Util.h suggests Halide should be built with -UNDEBUG,
i wish it would be either better documented or better yet cmakefiles should add_compile_definitions("-UNDEBUG")...

Thanks!

[alexreinking]

or better yet cmakefiles should add_compile_definitions("-UNDEBUG")...

As a matter of policy, we do not use directory commands in the Halide CMake codebase. Instead, we prefer the target_* prefixed commands, such as target_compile_definitions. Which targets are causing problems here? Is there something that isn't covered by the following code?

Halide/cmake/HalideTestHelpers.cmake

Lines 5 to 7 in 59f4fff

	include(WipeStandardFlags)
	wipe_standard_flags("[/-]D *NDEBUG")
	wipe_standard_flags("[/-]O[^ ]+")

[LebedevRI]

No, it does not appear to be sufficient:
https://buildd.debian.org/status/fetch.php?pkg=halide&arch=i386&ver=19.0.0-3&stamp=1736407332&raw=0
Maybe it needs to also wipe CMAKE_${L}_FLAGS?