Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nohang:1180: SyntaxWarning: "is" with a literal. Did you mean "=="? #107

Closed
FabioPedretti opened this issue Oct 17, 2020 · 5 comments
Closed

Comments

@FabioPedretti
Copy link

Installed nohang 0.1-1.1 from Ubuntu 20.10 official package. Running it I get:

$ nohang
/usr/sbin/nohang:1180: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if result is 0:
/usr/sbin/nohang:1341: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if n is 2:
The path to the config: /etc/nohang/nohang.conf
Monitoring started!

Having a quick look at the upstream code this is likely already fixed, so think this as a suggestion to make a new official release, so that distros can get the latest fixes!

Thanks!

@hakavlad
Copy link
Owner

Ok, thanks!

@hakavlad
Copy link
Owner

@FabioPedretti I don't recommend to use this outdated and buggy 0.1 release. See https://github.com/hakavlad/nohang/blob/master/CHANGELOG.md

I recommend to use the latest snapshot. 0.2 coming soon.

@FabioPedretti
Copy link
Author

Great, thanks for the quick reply!

@FabioPedretti
Copy link
Author

BTW I can confirm the SyntaxWarnings are fixed in the git version, hopefully a new release will be released soon, official Debian/Ubuntu packages updated and their users will get latest code. In the meantime see #73 for updated packages.

@FabioPedretti
Copy link
Author

Let's close this one, since it's actually fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants