Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nullable<'t> helpers to Expect module #478

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

bisen2
Copy link
Contributor

@bisen2 bisen2 commented Sep 19, 2023

This PR adds the helper functions suggested in #477 for asserting if a Nullable<'t> wraps a null value or not.

@@ -69,6 +69,16 @@ let tests =
) |> assertTestFails
]

testList "null value tests" [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test the passing cases too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is probably best. I am going to add those tests now.

@farlee2121 farlee2121 merged commit ef7ccd6 into haf:main Sep 20, 2023
@farlee2121
Copy link
Collaborator

Sorry this slipped through the cracks. It's just been release with 10.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants