From d3db9f71a04bfe11300efeb3e0f62d4a5e2e93d7 Mon Sep 17 00:00:00 2001 From: Jimmy Byrd Date: Thu, 18 Apr 2024 22:56:12 -0400 Subject: [PATCH] cleanup --- Expecto/Expecto.Impl.fs | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/Expecto/Expecto.Impl.fs b/Expecto/Expecto.Impl.fs index ebcb8d3e..83d33665 100644 --- a/Expecto/Expecto.Impl.fs +++ b/Expecto/Expecto.Impl.fs @@ -10,20 +10,6 @@ open Expecto.Logging.Message open Helpers open Mono.Cecil -//! The other option is to use a dedicated activity source for Expecto instead of adding it to the config - -// module ActivitySource = - -// let [] serviceName = "Expecto" // Should be public so consumers have a strong name when adding Sources -// let private version = lazy ( -// let assembly = typeof.Assembly -// let version = assembly.GetName().Version -// version.ToString() -// ) - -// let internal activitySource = lazy new ActivitySource(serviceName, version.Value) - - // TODO: make internal? module Impl = @@ -535,11 +521,6 @@ module Impl = colour: ColourLevel /// Split test names by `.` or `/` joinWith: JoinWith - // One option is to allow the consumer to provide an activity source - // only problem is the only way to update the config is by using the CLIArguments currently - // we would have to add a new CLIArgument but that doesn't really work as it's not a reallyCLI option - // or have another way of updating the config after it's been created - activitySource : ActivitySource option } static member defaultConfig = { runInParallel = true @@ -566,7 +547,6 @@ module Impl = noSpinner = false colour = Colour8 joinWith = JoinWith.Dot - activitySource = None } member x.appendSummaryHandler handleSummary =