From a2c04c2da4ac6416b872edb33a26126c8ad53352 Mon Sep 17 00:00:00 2001 From: Xianzhu Wang Date: Mon, 27 Jun 2022 23:45:54 +0000 Subject: [PATCH] Remove dead code LocalFrame::DeviceScaleFactorChanged() I guess it was for pre-use-zoom-for-dsf. Now LocalFrame::SetPageAndTextZoomFactors() invalidates style on change of page zoom including dsf. Bug: 1296791 Change-Id: I31eb3fb380fa7274cae512eab99f957fffa54ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3726854 Auto-Submit: Xianzhu Wang Commit-Queue: Philip Rogers Reviewed-by: Philip Rogers Cr-Commit-Position: refs/heads/main@{#1018468} --- third_party/blink/renderer/core/frame/local_frame.cc | 12 ------------ third_party/blink/renderer/core/frame/local_frame.h | 1 - 2 files changed, 13 deletions(-) diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc index 9d8a9be49ed025..e80a35651a638f 100644 --- a/third_party/blink/renderer/core/frame/local_frame.cc +++ b/third_party/blink/renderer/core/frame/local_frame.cc @@ -1286,18 +1286,6 @@ void LocalFrame::SetPageAndTextZoomFactors(float page_zoom_factor, View()->SetNeedsLayout(); } -void LocalFrame::DeviceScaleFactorChanged() { - GetDocument()->MediaQueryAffectingValueChanged(MediaValueChange::kOther); - GetDocument()->GetStyleEngine().MarkViewportStyleDirty(); - GetDocument()->GetStyleEngine().MarkAllElementsForStyleRecalc( - StyleChangeReasonForTracing::Create(style_change_reason::kZoom)); - for (Frame* child = Tree().FirstChild(); child; - child = child->Tree().NextSibling()) { - if (auto* child_local_frame = DynamicTo(child)) - child_local_frame->DeviceScaleFactorChanged(); - } -} - void LocalFrame::MediaQueryAffectingValueChangedForLocalSubtree( MediaValueChange value) { GetDocument()->MediaQueryAffectingValueChanged(value); diff --git a/third_party/blink/renderer/core/frame/local_frame.h b/third_party/blink/renderer/core/frame/local_frame.h index 669d4ec1b5bde2..ba6e2a7c46d629 100644 --- a/third_party/blink/renderer/core/frame/local_frame.h +++ b/third_party/blink/renderer/core/frame/local_frame.h @@ -357,7 +357,6 @@ class CORE_EXPORT LocalFrame final void SetPageAndTextZoomFactors(float page_zoom_factor, float text_zoom_factor); - void DeviceScaleFactorChanged(); double DevicePixelRatio() const; // Informs the local root's document and its local descendant subtree that a