From 7babdb56de9665d928be7e66531c7d6daf2af23c Mon Sep 17 00:00:00 2001 From: Jan Keitel Date: Fri, 24 Jun 2022 13:15:32 +0000 Subject: [PATCH] [APC Desktop] Expose flag for password change from settings on Desktop. Bug: 1316316 Change-Id: I033681c602706df17445502cc8a0e33fe7a2aa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3720663 Reviewed-by: Vasilii Sukhanov Commit-Queue: Jan Keitel Cr-Commit-Position: refs/heads/main@{#1017596} --- chrome/browser/about_flags.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index 49832d2c643759..b31dffaf3aeddf 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -2523,7 +2523,6 @@ const FeatureEntry::FeatureVariation kPasswordChangeFeatureVariations[] = { kPasswordChangeVariationWithForcedDialogAfterEverySuccessfulSubmission), nullptr}}; -#if BUILDFLAG(IS_ANDROID) // The variations of --password-change-in-settings. const FeatureEntry::FeatureParam kPasswordChangeInSettingsVariationWithForcedWarningForEverySite[] = { @@ -2539,6 +2538,7 @@ const FeatureEntry::FeatureVariation kPasswordChangeInSettingsVariationWithForcedWarningForEverySite), nullptr}}; +#if BUILDFLAG(IS_ANDROID) // The variations of --touch-to-fill-password-submission. const FeatureEntry::FeatureParam kTouchToFillPasswordSubmissionWithConservativeHeuristics[] = { @@ -6936,20 +6936,19 @@ const FeatureEntry kFeatureEntries[] = { FEATURE_WITH_PARAMS_VALUE_TYPE(password_manager::features::kPasswordChange, kPasswordChangeFeatureVariations, "PasswordChangeFeatureVariations")}, - -#if BUILDFLAG(IS_ANDROID) {"password-change-in-settings", flag_descriptions::kPasswordChangeInSettingsName, - flag_descriptions::kPasswordChangeInSettingsDescription, kOsAndroid, + flag_descriptions::kPasswordChangeInSettingsDescription, kOsAll, FEATURE_WITH_PARAMS_VALUE_TYPE( password_manager::features::kPasswordChangeInSettings, kPasswordChangeInSettingsFeatureVariations, "PasswordChangeInSettingsFeatureVariations")}, + +#if BUILDFLAG(IS_ANDROID) {"password-scripts-fetching", flag_descriptions::kPasswordScriptsFetchingName, flag_descriptions::kPasswordScriptsFetchingDescription, kOsAndroid, FEATURE_VALUE_TYPE(password_manager::features::kPasswordScriptsFetching)}, - #endif // BUILDFLAG(IS_ANDROID) #if BUILDFLAG(IS_ANDROID)