Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - Implement Prettier code formatting standard #1887

Open
1 task
Tracked by #1877
DrAcula27 opened this issue Jan 9, 2025 · 6 comments
Open
1 task
Tracked by #1877

DEV - Implement Prettier code formatting standard #1887

DrAcula27 opened this issue Jan 9, 2025 · 6 comments
Labels
Complexity: Small draft Feature: Code Health Make our code more readable, testable, and modular ready for dev lead ready for developer lead to review the issue Role: Frontend React front end work size: 0.50pt Can be done in 3 hours

Comments

@DrAcula27
Copy link
Member

DrAcula27 commented Jan 9, 2025

Overview

Propose formatting standard for the 311 Data repo with Prettier

More Info (optional)

Consider finding an existing open source project with well-documented code formatting rules that would work well with our codebase

Action Items

  • Propose a code formatting standard. Consider providing...
    • .prettierrc
    • .editorconfig
    • examples of this formatting configuration on another repo

Resources/Instructions

@DrAcula27 DrAcula27 added Role: Frontend React front end work Feature: Code Health Make our code more readable, testable, and modular ready for dev lead ready for developer lead to review the issue size: 0.50pt Can be done in 3 hours draft Milestone: X - Technical Debt Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) labels Jan 9, 2025
@DrAcula27 DrAcula27 added this to the X - Technical Debt milestone Jan 9, 2025
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Jan 9, 2025
@ryanfchase ryanfchase added Complexity: Small and removed Complexity: Missing This ticket needs a complexity (good first issue, small, medium, or large) labels Jan 9, 2025
@ryanfchase ryanfchase self-assigned this Jan 12, 2025
@ryanfchase ryanfchase removed their assignment Jan 12, 2025
@ryanfchase ryanfchase moved this from New Issue Approval to Prioritized Backlog in P: 311: Project Board Jan 12, 2025
@ryanfchase ryanfchase removed ready for prioritization ready for dev lead ready for developer lead to review the issue labels Jan 12, 2025
@efrenmarin45
Copy link
Member

The article goes over setting up Prettier and automating the formatting process by using git hooks. The two files used to format in the example (.prettierrc, .editorconfig) uses the default formatting VSCode comes with out the box. I'd recommend trying out the workflow locally on a personal project to get the gist of how formatting works.

@traycn traycn changed the title Implement Prettier code formatting standard DEV - Implement Prettier code formatting standard Jan 15, 2025
@bphan002 bphan002 moved this from Prioritized Backlog to In progress in P: 311: Project Board Jan 18, 2025
@bphan002 bphan002 moved this from In progress to Prioritized Backlog in P: 311: Project Board Jan 18, 2025
@ryanfchase
Copy link
Member

This ticket is ready to be picked up 👍

@traycn
Copy link
Member

traycn commented Jan 21, 2025

Hey @ryanfchase

Let's move this ticket back to Icebox as the Action Items aren't clearly defined and would have to involve collaboration with the dev team. I propose we follow these steps as individual Dev issues for the Epic (#1877):

  1. Update this ticket with action items to add Prettier to our application with a default formatting dev team agrees on.
  2. Developers run Prettier's default formatting locally to:
    • address any bugs/issues we come across
    • share our thoughts for custom formatting we'd like to implement as a team
      • define the teams standard for code formatting
      • NOTE: Add docs OR reference prettier config for devs to know what the teams formatting standards are
  3. Update Prettier with the teams standard on code formatting in the config.

Btw @efrenmarin45 I really appreicate your article on Prettier! I agree with running Prettier locally. In our next team meeting let's all discuss the intent behind formatting and talk next steps in using Prettier in our development workflow.

@ryanfchase
Copy link
Member

ryanfchase commented Jan 22, 2025

@traycn works for me, but I think we should just incorporate your proposed list into the action items of this ticket. I don't see a point of splitting it into multiple tickets when one dev should be responsible for integrating the prettier config files.

If Steps 1-3 are integrated into this ticket, then we can remove my proposed ticket "Implement and test Prettier configuration files" and "Implement and test Prettier configuration files" from the Epic.

Do you have thoughts on when we should actually perform and commit a Prettier format for the entire codebase?

@ryanfchase ryanfchase moved this from Prioritized Backlog to New Issue Approval in P: 311: Project Board Jan 22, 2025
@ryanfchase ryanfchase added the ready for dev lead ready for developer lead to review the issue label Jan 22, 2025
@ryanfchase
Copy link
Member

Moved ticket to New Issue Approval since we are discussing Action Items.

@traycn
Copy link
Member

traycn commented Jan 23, 2025

Let's set this ticket for Post-Launch and start working on this implementation when we're more moved along with Pre-Launch.

Concerning the Epic for this Prettier implentation, what was the reasoning behind creating an Epic? Also how do PMs decide on when a task is an Epic or an individual issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small draft Feature: Code Health Make our code more readable, testable, and modular ready for dev lead ready for developer lead to review the issue Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Projects
Status: New Issue Approval
Development

No branches or pull requests

4 participants