Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I found a issue, I'm not sure wether it's a problem , pls check. #176

Closed
skyismine2010 opened this issue Oct 9, 2018 · 4 comments
Closed

Comments

@skyismine2010
Copy link

skyismine2010 commented Oct 9, 2018

During sending email , the function in flask_mail.py 163 line

def configure_host(self):
    if self.mail.use_ssl:  --- but i'ts  string type, not a boolean type.
        host = smtplib.SMTP_SSL(self.mail.server, self.mail.port)
    else:
        host = smtplib.SMTP(self.mail.server, self.mail.port)

    host.set_debuglevel(int(self.mail.debug))

pls check , Tks
BR from yqqls

@sandlerben
Copy link
Contributor

Can you link to where it's defined?

@skyismine2010
Copy link
Author

Can you link to where it's defined?

It's defined in flask_mail.py line:549 (master branch)
self.mail.use_ssl is assigned in _mail construct function by config.get
like this:
config.get('MAIL_USE_TLS', False)
the config object is inherited from dict , it's defined in flask/config.py , it maybe string type in some condition.

@sandlerben
Copy link
Contributor

Sounds like you think there might be a bug in the library. Feel free to make an issue on their repo and link it here.

@sandlerben
Copy link
Contributor

I think this is intended behavior though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants