Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest should inherit NestedManifest? #20

Open
Villux opened this issue Aug 26, 2019 · 2 comments
Open

Manifest should inherit NestedManifest? #20

Villux opened this issue Aug 26, 2019 · 2 comments
Assignees

Comments

@Villux
Copy link
Contributor

Villux commented Aug 26, 2019

Concepts are not clear with NestedManifest and Manifest. This will lead to problems when repository and all hmt-servers products grow.

When new field is added to Manifest it's required (?) for NestedManifest as well. At least it's hard to say when it's needed and when it's not. This will lead to code duplication and it should be avoided always.

If manifest would inherit from nested manifest duplicate fields would be only in NestedManifest. And maybe NestedManifest could be called BaseManifest with a good description that tells where that's used and what should be in it.

@gaieges
Copy link
Contributor

gaieges commented Aug 26, 2019

Nested manifest was an artifact of some quick work around customer jobs. We probably still want something along those lines but the manifest should be the core thing that defines the available keys / options.

The nested manifest should really just be a wrapper to allow a 2..N or more manifests to be wrapped within it. I presume it is the way that it is due to restrictions in schematics

@e271828-
Copy link
Contributor

Not all keys should be in a NestedManifest, but this was indeed a quick patch and not the cleanest approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants