You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Concepts are not clear with NestedManifest and Manifest. This will lead to problems when repository and all hmt-servers products grow.
When new field is added to Manifest it's required (?) for NestedManifest as well. At least it's hard to say when it's needed and when it's not. This will lead to code duplication and it should be avoided always.
If manifest would inherit from nested manifest duplicate fields would be only in NestedManifest. And maybe NestedManifest could be called BaseManifest with a good description that tells where that's used and what should be in it.
The text was updated successfully, but these errors were encountered:
Nested manifest was an artifact of some quick work around customer jobs. We probably still want something along those lines but the manifest should be the core thing that defines the available keys / options.
The nested manifest should really just be a wrapper to allow a 2..N or more manifests to be wrapped within it. I presume it is the way that it is due to restrictions in schematics
Concepts are not clear with
NestedManifest
andManifest
. This will lead to problems when repository and all hmt-servers products grow.When new field is added to Manifest it's required (?) for NestedManifest as well. At least it's hard to say when it's needed and when it's not. This will lead to code duplication and it should be avoided always.
If manifest would inherit from nested manifest duplicate fields would be only in NestedManifest. And maybe NestedManifest could be called BaseManifest with a good description that tells where that's used and what should be in it.
The text was updated successfully, but these errors were encountered: