-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show differences from existing methods #3
Comments
@MichaelJFishman Is the intent to distinguish scoping from these others, or to improve clarity by explaining scoping better in terms of existing techniques? If it's the former, we should make an additional issue for the latter. |
At least the latter. Review 2.4 says
Edit: This comment is more relevant to #15 . |
Specific methods to relate to:
|
Rewording: Use standard verbiage to make our method more clear, and to compare and contrast to existing methods. |
Expressing PPP using merge-and-shrink is a messIt seems that expressing PPP as a composition of shrink, prune, label reduce, label prune transformations will a mess. The shrink transformation will throw away information we need at one of the label-pruning steps of PPP. In particular: Part of a PPP transformation is, in order
The problem is that for FTS, we’d use the shrink transformation to ignore effects on vshrink, but the shrink transformation will remove any conditioning on vshrink. We could
But this seems messier than our existing description. Mermaid graph of this. Solid lines are between FTS, their transformation, and the output FTS. Dashed lines indicate that a transformation definition is based on the source FTS. graph LR
X0
X1
X2
X3
X4
F0(("shrink"))
F1(("label reduce"))
F2(("label prune"))
F3(("shrink"))
X0 --> F0 --> X1
X1 -.-> F1
X0 -->F1-->X2
X2 --> F2 --> X3
X3 --> F3 --> X4
graph LR
X0
X1
X2
X3
X4
F0[/"shrink vshrink"/]
F1[/"reduce labels based on the effect-equivalence of their images in X1"/]
F2[/"prune labels which condition on vshrink"/]
F3[/"shrink vshrink"/]
X0 --> F0 --> X1
X1 -.-> F1
X0 -->F1-->X2
X2 --> F2 --> X3
X3 --> F3 --> X4
Moving forwardsThere may be another step left in PPP after the above. I'm not sure, and I don't know if we need to find out. I think a minimal path is:
|
What does vshrink mean? |
Set of variables that will be shrunk to a single value each. V_projected or
v_irrelevant in the paper/code.
…On Thu, Dec 29, 2022 at 3:33 PM Cam Allen ***@***.***> wrote:
What does vshrink mean?
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBOIQIJOYIFUO33GZMS2Y3WPXYSLANCNFSM57UAW7SA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Some reviews asked how this differs from existing methods. Explain the differences.
The text was updated successfully, but these errors were encountered: