From 13c31f03c18b57eae21d5d02c43358ff0af09f1e Mon Sep 17 00:00:00 2001
From: gwenn <gtreguier@gmail.com>
Date: Tue, 2 Jan 2024 19:57:37 +0100
Subject: [PATCH] Make possible to perform extra consistency checks

---
 src/parser/ast/mod.rs | 52 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 47 insertions(+), 5 deletions(-)

diff --git a/src/parser/ast/mod.rs b/src/parser/ast/mod.rs
index c35d6ac..a408743 100644
--- a/src/parser/ast/mod.rs
+++ b/src/parser/ast/mod.rs
@@ -155,6 +155,15 @@ impl Display for Cmd {
 }
 
 impl Cmd {
+    /// Statement accessor
+    pub fn stmt(&self) -> &Stmt {
+        match self {
+            Cmd::Explain(stmt) => stmt,
+            Cmd::ExplainQueryPlan(stmt) => stmt,
+            Cmd::Stmt(stmt) => stmt,
+        }
+    }
+
     /// Like `sqlite3_column_count` but more limited
     pub fn column_count(&self) -> ColumnCount {
         match self {
@@ -166,11 +175,12 @@ impl Cmd {
 
     /// Like `sqlite3_stmt_readonly`
     pub fn readonly(&self) -> bool {
-        match self {
-            Cmd::Explain(stmt) => stmt.readonly(),
-            Cmd::ExplainQueryPlan(stmt) => stmt.readonly(),
-            Cmd::Stmt(stmt) => stmt.readonly(),
-        }
+        self.stmt().readonly()
+    }
+
+    /// check for extra rules
+    pub fn check(&self) -> Result<(), ParserError> {
+        self.stmt().check()
     }
 }
 
@@ -767,6 +777,38 @@ impl Stmt {
             _ => false,
         }
     }
+
+    /// check for extra rules
+    pub fn check(&self) -> Result<(), ParserError> {
+        match self {
+            Stmt::CreateTable { body, .. } => Ok(()), // TODO ...
+            Stmt::CreateView {
+                columns: Some(columns),
+                select,
+                ..
+            } => {
+                match select.body.select.column_count() {
+                    ColumnCount::Fixed(n) if n != columns.len() => Err(ParserError::Custom(
+                        format!("incoherent column numbers {} <> {}", columns.len(), n),
+                    )), // TODO find original SQLite error msg
+                    _ => Ok(()),
+                }
+            }
+            Stmt::Insert {
+                columns: Some(columns),
+                body: InsertBody::Select(select, ..),
+                ..
+            } => {
+                match select.body.select.column_count() {
+                    ColumnCount::Fixed(n) if n != columns.len() => Err(ParserError::Custom(
+                        format!("incoherent column numbers {} <> {}", columns.len(), n),
+                    )), // TODO find original SQLite error msg
+                    _ => Ok(()),
+                }
+            }
+            _ => Ok(()),
+        }
+    }
 }
 
 // https://sqlite.org/syntax/expr.html