Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGRB post processing and results webpage #3660

Open
pannarale opened this issue Mar 8, 2021 · 9 comments
Open

PyGRB post processing and results webpage #3660

pannarale opened this issue Mar 8, 2021 · 9 comments
Assignees
Labels
PyGRB PyGRB development work in progress

Comments

@pannarale
Copy link
Contributor

pannarale commented Mar 8, 2021

We have a first take on the PyGRB results webpage in the standard PyCBC format here. Right now it has most of what was on the old webpages, but there is a lot more that can and should be done. So use this issue to bring up bugs, desiderata, etc.

@pannarale pannarale added the PyGRB PyGRB development label Mar 8, 2021
@pannarale pannarale added this to the PyGRB - Phase 1 milestone Mar 8, 2021
@pannarale pannarale self-assigned this Mar 8, 2021
@pannarale
Copy link
Contributor Author

pannarale commented Mar 9, 2021

Still missing from the old pages

  • GRB trigger information
  • table of loudest offsource events with details
  • Values of 50% and 90% exclusion distances

@pannarale
Copy link
Contributor Author

pannarale commented Mar 9, 2021

Known requests

  • Include GPS times of injections in tables
  • Follow up of loudest missed injections
  • Follow up of loudest offsource events
  • Sample the offtrials randomly (this requires changes to pycbc_grb_trig_combiner at line 464)
  • Include in tables information regarding the spins of templates ringing with triggers/injections (this is postponed to after the switch to hdf5)
  • Sky maps with antenna responses

@titodalcanton
Copy link
Contributor

titodalcanton commented Jun 3, 2021

@pannarale could you also consider the following requests:

  • I have a hard time reading found/missed injection plots. I propose using higher-resolution plots (try dpi=150 or dpi=200, or double the figure size), smaller symbols, consistent use of the makers (x = missed, o = found) and no mix of blue and black symbols.
  • Found/missed plots with some kind of optimal SNR on the y axis. Not sure which one gives the sharpest separation between found and missed in a coherent search though, so this may require comparing a few different choices (e.g. optimal network SNR or decisive optimal SNR).
  • Try a log10 FAP color scale, I suspect it would be more useful: 0.8 and 0.2 basically indicate the same conclusion, while 0.05 and 0.0005 imply very different results.
  • Add a tiny and very brief legend on the bottom left or bottom right of the figure, indicating what the various symbols mean.

@a-r-williamson a-r-williamson moved this to In Progress in PyGRB Development Mar 30, 2022
@a-r-williamson a-r-williamson changed the title PyGRB results webpage PyGRB post processing and results webpage Mar 30, 2022
@a-r-williamson a-r-williamson linked a pull request Mar 30, 2022 that will close this issue
@a-r-williamson a-r-williamson removed a link to a pull request Mar 30, 2022
@pannarale
Copy link
Contributor Author

#4639 may need some fixes downstream in the post-processing, as noted in the PR's thread.

@pannarale
Copy link
Contributor Author

pannarale commented Apr 18, 2024

  • @jakeb245, per the discussion we had today about extract_basic_trig_properties, please add the argument opts in pycbc_pygrb_efficiency when the extract_basic_trig_properties function call happens.

@pannarale
Copy link
Contributor Author

pannarale commented Apr 23, 2024

Moving more webpage/post-processing tasks here from issue #4419.

Comparing the latest results webpage to the most complete one generated when using old xml results files, the items missing are

  • tables of missed and quiet injections (A31 and A32)
  • follow ups of the 10 loudest quiet injections (sections 3.02 and 3.04, these are done for each injection set)
  • all section 4, i.e., loudest offsource events distributions, table and follow ups of the 10 loudest
  • all of section 5 (exclusion distances)

@pannarale
Copy link
Contributor Author

pannarale commented Apr 29, 2024

On the basis of the April 2024 test I am marking some of the items in the previous comment as done. The remaining items are

  • reporting the exclusion distances
  • testing opening a box

@pannarale
Copy link
Contributor Author

[x] @jakeb245, per the discussion we had today about extract_basic_trig_properties, please add the argument opts in pycbc_pygrb_efficiency when the extract_basic_trig_properties function call happens.

Done in #4718

@pannarale
Copy link
Contributor Author

On the basis of the April 2024 test I am marking some of the items in the previous comment as done. The remaining items are

  • reporting the exclusion distances
  • testing opening a box

An example of these is here. PRs to be written and opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development work in progress
Projects
Status: In Progress
Development

No branches or pull requests

3 participants