Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial with example profile #16

Open
gunnarvoet opened this issue Apr 28, 2020 · 5 comments
Open

Add tutorial with example profile #16

gunnarvoet opened this issue Apr 28, 2020 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@gunnarvoet
Copy link
Owner

No description provided.

@gunnarvoet gunnarvoet added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 28, 2020
@hdrake hdrake self-assigned this Oct 13, 2021
@hdrake
Copy link
Collaborator

hdrake commented Oct 13, 2021

I'm working on it. I don't know if the profiles I'm working with are particularly clean already, but it is hard to see the effect of each individual processing step.

So instead I'm taking the approach of purposefully corrupting the example profile and then making sure each processing step is doing the intended fix.

For example, here is the the before and after of the first processing step ctd_cleanup, which includes: 1) pressure despike, 2) T/S despite, 3) get rid of unphysical out-of-bound values, 4) get rid of some surface data.

Screen Shot 2021-10-13 at 7 04 31 AM

@gunnarvoet, what do you think of a tutorial that steps through a corrupted example profile in this way? I think it would also be nice to re-use the exact same profile in https://github.com/modscripps/mixsea and any other related packages (what do you think @jessecusack?)

@gunnarvoet gunnarvoet pinned this issue Oct 15, 2021
@gunnarvoet gunnarvoet unpinned this issue Oct 15, 2021
@gunnarvoet
Copy link
Owner Author

I like your idea of introducing clearly visible data issues, at least where this is possible. Another option would be to zoom in on regions where changes happen, for example, loop editing is hard to identify on a full profile but becomes more apparent when looking at a depth range of 10m or so.

@hdrake
Copy link
Collaborator

hdrake commented Oct 15, 2021

@gunnarvoet I think you're right that for the more subtle processing steps we will need to really zoom in on particular features. I think the best idea will be to pick out a profile that already has a lot of variance and ideally even some big overturns so that the quality of the profile can be tracked through all of the steps and then it can lead straight into an example in mixsea (where we could show how the processing affects mixing rate estimates, by comparing a raw binned profile to the fully processed one).

@gunnarvoet
Copy link
Owner Author

@hdrake that sounds great.

@jessecusack
Copy link

I think illustrating the processing of noisy data using ctdproc before passing that on to mixsea would be a really nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants