Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection criterion parameter _selection_criteria_ set to IV throws error for binning with continuous target #307

Open
jnsofini opened this issue Mar 13, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@jnsofini
Copy link
Contributor

When binning with with continuous target, the selection_criteria parameter for the binning object throws an error when set to IV. At first I checked the binning_process.summary() and there was no IV. Thought it makes sense. However, I noticed we have IVs for continuous target binning present in binning_process.get_binned_variable("feature-name").binning_table.iv.

Is this intended that we can't use IV as selection for continuous target, and why? If on the other hand it is possible to use IV selection criteria for continuous target could we get it included in the binning_process.summary() as well and also be available for selection criteria along side woe and quality_score?

@guillermo-navas-palencia
Copy link
Owner

Hi @jnsofini.

It was intended some time ago before I had an "IV" for a continuous target. It should be as simple as updating this dictionary. Regarding the second question, yes, it should be straightforward.

@guillermo-navas-palencia guillermo-navas-palencia added the enhancement New feature or request label Mar 31, 2024
@guillermo-navas-palencia guillermo-navas-palencia added this to the v0.20.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants