Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type "Date" missing? #9

Open
janober opened this issue Jan 29, 2015 · 3 comments
Open

Data type "Date" missing? #9

janober opened this issue Jan 29, 2015 · 3 comments

Comments

@janober
Copy link

janober commented Jan 29, 2015

Just tried the user authentication after having switched "AccessToken" to couchbase.

Creating one works fine, but as soon as I use it I get the error "'token.created must be a valid Date".

The code which causes that error messages in "access-token.js" is:

      assert(
          this.created && typeof this.created.getTime === 'function',
        'token.created must be a valid Date'
      );

So I guess that the data type "Date" is not implemented yet?

@janober
Copy link
Author

janober commented Feb 10, 2015

The type "Date" was missing like I expected. Here is the commit which fixes it:
janober@535c458

After not having heard anything since 2 weeks on any of my issues/questions/comments and not being sure that my input is really disired I decided yesterday to fork. I removed all the N1QL code because I do not need the complex queries, all I care for is speed. Hope that is also helpful for other people. So will stop posting further issues here and post them in my fork instead. If you decide to keep on working on the connector in the future, I hope the fixes in my fork are of help (think I fixed more or less all the issues I did create and posted the link to the commit with the fix). Will also check for future commits here which are helpful for my fork.

Good luck!

@nolandubeau
Copy link
Contributor

Hi Jan,

We haven't been ignoring you, we've just been heads down on product
development and haven't been able to re-group on your issues/posts. Our
lead dev on the connector is also away right now, but will be back next
week. Could I suggest that we do a Google hangout next week sometime and
we can go through the items? Where are you located?

On Tue, Feb 10, 2015 at 5:52 PM, Jan [email protected] wrote:

The type "Date" was missing like I expected. Here is the commit which
fixes it:
janober/loopback-connector-couchbase-expert@535c458
janober@535c458

After not having heard anything since 2 weeks on any of my
issues/questions/comments and not being sure that my input is really
disired I decided yesterday to fork. I removed all the N1QL code because I
do not need the complex queries, all I care for is speed. Hope that is also
helpful for other people. So will stop posting further issues here and post
them in my fork instead. If you decide to keep on working on the connector
in the future, I hope the fixes in my fork are of help (think I fixed more
or less all the issues I did create and posted the link to the commit with
the fix). Will also check for future commits here which are helpful for my
fork.

Good luck!


Reply to this email directly or view it on GitHub
#9 (comment)
.

_Nolan Dubeau_VP, Engineering, Guardly Corp.
Online: https://www.guardly.com
LinkedIn: http://www.linkedin.com/in/nolandubeau
20 Maud Street, Suite 307, Toronto, ON M5V 2M5
CA (416) 434-8029 | US (650) 262-3599 | Skype: nolandubeau
Please consider the environment before printing this email.

@janober
Copy link
Author

janober commented Feb 11, 2015

Sorry did probably not phrase is very well. Did not just fork because I did not get answers. One of the most important reason for the fork was that the more I worked with the connector the more I understood that N1QL is simply not ready yet and actually not needed for my specific case. It just adds complexity where it is not needed, additional lag and resources. I query to 98% by id so really no need for N1QL at all.
When N1QL is production ready I will probably think about it and evaluate again but at the moment it does not really make sense because I just care about speed. But like mentioned above I still hope that the code you and I write will help both. So that we get proper Couchbase integration into Loopback (no matter if or without N1QL).

Sure would be open for a chat. I am currently located in Mexico so the time difference should not be a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants