Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save & destroyAll missing #6

Open
janober opened this issue Jan 28, 2015 · 4 comments
Open

save & destroyAll missing #6

janober opened this issue Jan 28, 2015 · 4 comments

Comments

@janober
Copy link

janober commented Jan 28, 2015

After testing changing some of my datasources to couchbase, loopback did always stop and exit with the message "stop here". After looking through the code in "lib/cb.js" I found the reason. It seems like that "save" (which I did use, Line 217) and "destroyAll" (Line 339) are not implemented yet.

@nolandubeau
Copy link
Contributor

Hi yes this is correct. We have yet to complete those features. I will
check with our team tomorrow on timing for that, but feel free to submit a
PR should you want to contribute those methods.

On Tue, Jan 27, 2015 at 7:06 PM, Jan [email protected] wrote:

After testing changing some of my datasources to couchbase, loopback did
always stop and exit with the message "stop here". After looking through
the code in "lib/cb.js" I found the reason. It seems like that "save"
(which I did use, Line 217) and "destroyAll" (Line 339) are not implemented
yet.


Reply to this email directly or view it on GitHub
#6.

_Nolan Dubeau_VP, Engineering, Guardly Corp.
Online: https://www.guardly.com
LinkedIn: http://www.linkedin.com/in/nolandubeau
20 Maud Street, Suite 307, Toronto, ON M5V 2M5
CA (416) 434-8029 | US (650) 262-3599 | Skype: nolandubeau
Please consider the environment before printing this email.

@janober
Copy link
Author

janober commented Jan 28, 2015

I added at least the "save" it looked simple enough. Is in my fork. Sorry should probably have created a different branch because do not see a way to create a pull request as long as the other one is still open. Do sadly have not to much experience with github... Maybe next time directly a branch...

With the destroyAll. I was not sure how to most efficiently get all the instances so I left it before I code total crap which you can then not use in the end anyway. Hope at least the save is usefull.

@nolandubeau
Copy link
Contributor

Great. If you want to post the code for the save() I can get it merged
in. Will look into destroyAll() tomorrow. Thanks.

On Tue, Jan 27, 2015 at 8:24 PM, Jan [email protected] wrote:

I added at least the "save" it looked simple enough. Is in my fork. Sorry
should probably have created a different branch because do not see a way to
create a pull request as long as the other one is still open. Do sadly have
not to much experience with github... Maybe next time directly a branch...

With the destroyAll. I was not sure how to most efficiently get all the
instances so I left it before I code total crap which you can then not use
in the end anyway. Hope at least the save is usefull.


Reply to this email directly or view it on GitHub
#6 (comment)
.

_Nolan Dubeau_VP, Engineering, Guardly Corp.
Online: https://www.guardly.com
LinkedIn: http://www.linkedin.com/in/nolandubeau
20 Maud Street, Suite 307, Toronto, ON M5V 2M5
CA (416) 434-8029 | US (650) 262-3599 | Skype: nolandubeau
Please consider the environment before printing this email.

@janober
Copy link
Author

janober commented Jan 28, 2015

The save code is here:
janober@69ba1cc

So "CouchbaseDB.prototype.save" from Line 217 and "CouchbaseDB.prototype.updateAttributes" Line 348. The other stuff is just WebStorm removing not needed spaces from the end of the lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants