You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
If no region is explicitly configured in com.gu.logback.appender.kinesis.BaseKinesisAppender#findRegion, then a hardcoded default of us-east-1 is used:
privateRegionfindRegion() {
booleanregionProvided = !Validator.isBlank(this.region);
if(!regionProvided) {
// Determine region from where application is running, or fall back to default regionreturnRegion.of(AppenderConstants.DEFAULT_REGION);
}
returnRegion.of(this.region);
}
It would be preferable to let the SDK default to the standard AWS region provider chain, which could be done simply by passing null into the client builder, by returning null, ie:
If no region is explicitly configured in
com.gu.logback.appender.kinesis.BaseKinesisAppender#findRegion
, then a hardcoded default ofus-east-1
is used:It would be preferable to let the SDK default to the standard AWS region provider chain, which could be done simply by passing null into the client builder, by returning null, ie:
The text was updated successfully, but these errors were encountered: