Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading or deprecating iframe-messenger #17

Open
SiAdcock opened this issue Sep 13, 2024 · 1 comment
Open

Consider upgrading or deprecating iframe-messenger #17

SiAdcock opened this issue Sep 13, 2024 · 1 comment

Comments

@SiAdcock
Copy link

SiAdcock commented Sep 13, 2024

We use this in several places (InstagramBlockComponent, UnsafeEmbedBlockComponent, emailEmbed), mainly to allow iframes to ask the parent doc to resize them.

It has not been updated in 10 years, and there are likely to be edge cases we're missing. We could use a well-maintained open source library. See https://github.com/davidjbradshaw/iframe-resizer

@SiAdcock SiAdcock changed the title Consider upgrading iframe-messenger Consider upgrading or deprecating iframe-messenger Sep 13, 2024
@emdash-ie
Copy link

emdash-ie commented Nov 4, 2024

Also now used in datawrapper-import (as of https://github.com/guardian/datawrapper-import/pull/4), which will need updating to use any replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants