From 4c21aa55e63413cb2a081576d119a57dcaf18f6b Mon Sep 17 00:00:00 2001 From: Jake Lee Kennedy Date: Fri, 17 Nov 2023 12:12:02 +0000 Subject: [PATCH] Fix label and centring when showing ads in merch slots (#26694) --- .../fragments/commercial/commercialComponent.scala.html | 2 +- package.json | 2 +- static/src/stylesheets/module/_adslot.scss | 3 ++- yarn.lock | 8 ++++---- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/common/app/views/fragments/commercial/commercialComponent.scala.html b/common/app/views/fragments/commercial/commercialComponent.scala.html index f740f058f5a2..e90cf05acd86 100644 --- a/common/app/views/fragments/commercial/commercialComponent.scala.html +++ b/common/app/views/fragments/commercial/commercialComponent.scala.html @@ -4,6 +4,6 @@ "merchandising", Seq("commercial-component"), Map(), - showLabel=false, + showLabel=true, refresh=false ){ } \ No newline at end of file diff --git a/package.json b/package.json index 518e0d12da7f..c30cbee1bf4b 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "@guardian/atom-renderer": "^2.0.0", "@guardian/automat-modules": "^0.3.8", "@guardian/braze-components": "^15.0.1", - "@guardian/commercial": "11.21.0", + "@guardian/commercial": "11.22.0", "@guardian/consent-management-platform": "13.7.1", "@guardian/core-web-vitals": "^5.0.0", "@guardian/identity-auth": "1.1.0", diff --git a/static/src/stylesheets/module/_adslot.scss b/static/src/stylesheets/module/_adslot.scss index ab6b9524228c..afb4a850431e 100644 --- a/static/src/stylesheets/module/_adslot.scss +++ b/static/src/stylesheets/module/_adslot.scss @@ -101,7 +101,8 @@ width: 100%; } -.ad-slot-container[top-above-nav-ad-rendered='true'] { +.ad-slot-container[top-above-nav-ad-rendered='true'], +.ad-slot-container--centre-slot { width: fit-content; margin: 0 auto; } diff --git a/yarn.lock b/yarn.lock index 7936aca8834f..5710b3a65c97 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2350,10 +2350,10 @@ resolved "https://registry.yarnpkg.com/@guardian/braze-components/-/braze-components-15.0.1.tgz#2c936c43e654f5ae28db254329eae1b4b5861641" integrity sha512-XNqYE9X/4aM5vZqiZInedvEZ9niPfdqwL7SjzNF0wnVbR+YObOC6QC68M521gTPcyca6r190qtnayv4GNO0peg== -"@guardian/commercial@11.21.0": - version "11.21.0" - resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-11.21.0.tgz#28bbd5adcc42d902d34e4b93d8357ba471b4db35" - integrity sha512-PG8as3pWnlvmEcU9ySb9sv1hKA4CMPyu9LyDgkP3gcvgKWCVNSdJSIujhpju9vgkf28WMF55+DDdcvsqRsEtsA== +"@guardian/commercial@11.22.0": + version "11.22.0" + resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-11.22.0.tgz#e9d6e168a08f3c02cc4050c4390bf571f26803e4" + integrity sha512-i9CUCtZTjfErKKgHFJ2jdJg/JqBO0mX8TQHBNQvhN7xN+68kQEFCTam26KDMY1d2OP/ZWVOjSFCYySXHB4+u/w== dependencies: "@changesets/cli" "^2.26.2" "@octokit/core" "^4.0.5"