Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get user from id function implemented and other functions updated #102

Merged
merged 11 commits into from
Feb 20, 2025

Conversation

anthonyle51
Copy link
Collaborator

No description provided.

@anthonyle51 anthonyle51 linked an issue Feb 18, 2025 that may be closed by this pull request
Copy link
Contributor

@DattaKansal DattaKansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.for searchFriends(), you need to return a list of Users not just a singular user since there could be multiple users matching that searchString.
2. in your getUserFromID(), you need to set values to null if they don't exist in firebase. Ex:
let myResponses = userData["myResponses"] as? [String] ?? []
3. in getIncomingRequests. make sure the collection is "USERS" not "users" since Firebase querying is case sensitive.
4. [Optional] If you want to add more test cases for testing anything, feel free to do so. Good job writing your own test case!

Copy link
Contributor

@DattaKansal DattaKansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@DattaKansal DattaKansal merged commit 8b191fd into profile-search-main Feb 20, 2025
@anthonyle51 anthonyle51 deleted the get_user_from_id branch February 23, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getUserFromId
2 participants