-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get user from id function implemented and other functions updated #102
Conversation
This reverts commit 25ccae1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.for searchFriends(), you need to return a list of Users not just a singular user since there could be multiple users matching that searchString.
2. in your getUserFromID(), you need to set values to null if they don't exist in firebase. Ex:
let myResponses = userData["myResponses"] as? [String] ?? []
3. in getIncomingRequests. make sure the collection is "USERS" not "users" since Firebase querying is case sensitive.
4. [Optional] If you want to add more test cases for testing anything, feel free to do so. Good job writing your own test case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
No description provided.