Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clang warnings that might be relevant #515

Open
jwpeterson opened this issue Dec 8, 2017 · 0 comments
Open

More clang warnings that might be relevant #515

jwpeterson opened this issue Dec 8, 2017 · 0 comments

Comments

@jwpeterson
Copy link
Collaborator

src/qoi/src/absorption_coeff.C:98:39: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
    for (unsigned int i=data_size-1; i>=0; i--)
                                     ~^ ~
../../src/physics/src/spalart_allmaras_stab_helper.C:91:188: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Wparentheses]
    libMesh::Number inv_sigmadivnuplusnuphysicalGradnu = (1./this->_sa_params.get_sigma())*(grad_nu*grad_nu + ((nu_value + mu)*(hess_nu(0,0) + hess_nu(1,1) + (this->_flow_vars.dim() == 3)?hess_nu(2,2):0)) + this->_sa_params.get_cb2()*grad_nu*grad_nu);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant