Update react peer dependency ranges to include v19
#1019
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
askoufis
changed the title
react peer dependency ranges to include v19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1014.
Appends
^19.0.0to thereactpeer dependencies in both the@loadable/componentand@loadable/serverpackages. I don't think there's anything about those package's usage ofreactthat would prevent React 19 from being compatible with them.Test plan
I struggled for a long time trying to get node v12 installed (via mise) as well as installing deps with
yarn. Having to install Python 2.x is a pain.Additionally, I had to replace a reference to what appears to be a private atlassian registry in the lockfile with a reference to the
yarnpkgregistry.After a while I gave up on node 12 and ran tests with node 16 (node 18 didn't work either) after manually executing parts of the
preparescript. All tests passed on my machine, though the repo is still using React 16 so the tests aren't really a guarantee that React 19 works. I didn't try updating the react dev deps to 19 for fear of more headaches, but happy to try it out if it's deemed necessary to merge this PR.Overall this was a very unpleasant contribution experience, though in fairness this repo doesn't exactly have regular contributions so it's understandable.