Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App restyling - Onboarding / Add key #146

Closed
dtonon opened this issue Nov 21, 2024 · 6 comments
Closed

App restyling - Onboarding / Add key #146

dtonon opened this issue Nov 21, 2024 · 6 comments

Comments

@dtonon
Copy link
Contributor

dtonon commented Nov 21, 2024

Reserved for the design

@dtonon
Copy link
Contributor Author

dtonon commented Nov 21, 2024

@greenart7c3 is technically possible to show informations about Orbot's setup inline in the main view? Or there are specific reasons to open a modal?

@dtonon dtonon changed the title App restyling - Onboarding App restyling - Onboarding / Add key Nov 21, 2024
@dtonon
Copy link
Contributor Author

dtonon commented Nov 21, 2024

This proposal integrate the Tor infos in the main screen.
The workflow should be identical both for the onboarding and the addition of new accounts.

image

@greenart7c3
Copy link
Owner

@greenart7c3 is technically possible to show informations about Orbot's setup inline in the main view? Or there are specific reasons to open a modal?

Yes it can be inline. I think i did this because i copied it from amethyst

@dtonon
Copy link
Contributor Author

dtonon commented Nov 21, 2024

i copied it from amethyst

I noticed that it was similar :)

@dtonon
Copy link
Contributor Author

dtonon commented Nov 21, 2024

Update, it's better for consistency with the "Create a new key" workflow, to move the Tor on the last screen:

image

@dtonon
Copy link
Contributor Author

dtonon commented Dec 10, 2024

Review of version 3.0.0-beta7

  • I would disable the "Next" button until a key is entered;
  • The "invalid key" notice should have the same font size of the basic text;
  • The "invalid key" notice should should hide as soon the user edit the input;

At the end of the procedure the user see a blank view with a "No permission granted" text. I would be more informative, I added a suggestion in the applications issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants