Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade moondancer-pac critical-section dependency #198

Closed
goo99x opened this issue Oct 24, 2024 · 0 comments · Fixed by #199
Closed

Upgrade moondancer-pac critical-section dependency #198

goo99x opened this issue Oct 24, 2024 · 0 comments · Fixed by #199
Assignees
@antoinevg
Labels
dependencies Pull requests that update a dependency file

Comments

@goo99x
Copy link

goo99x commented Oct 24, 2024

Older versions of critical-section have been yanked from crates.io. Upgrade the version to the only stable version: 1.2.0
I'm not doing a PR for this since I'd need a maintainer to make sure that this upgrade won't break existing code (I'm still getting familiar with the code base)

cynthion/firmware/moondancer-pac/Cargo.toml

Lines 34 to 35 in d8e8762

[dependencies]
critical-section = { version = "=1.1.1", optional = true }

@antoinevg antoinevg self-assigned this Oct 24, 2024
@antoinevg antoinevg mentioned this issue Oct 24, 2024
Merged
@antoinevg antoinevg added the dependencies Pull requests that update a dependency file label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinevg antoinevg

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pac: bump critical-section crate to version =1.2.0 antoinevg/cynthion
2 participants
@antoinevg @goo99x