Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Support custom repo location outside of chroot (picking up from #66) #67

Closed
Taijian opened this issue Mar 2, 2021 · 3 comments

Comments

@Taijian
Copy link
Contributor

Taijian commented Mar 2, 2021

Hi, it's me again!

Picking up from our conversation (mostly me babbling) on issue #66, I have a new patch that I'm using on my system and that seems to work fine, so I thought I'd just pitch it to you again, just to see if you might be interested.

It does two things:

  1. Add 2 new variables to $SKEL, allowing users to specify a custom repo location and name
  2. Adjust the code in clean-chroot-manager64.in to deal with the new variables and substitute them where appropriate in the code.

I hope this is more workable that the hacky 'solution' I came up with last year!

ccm.patch.txt

@graysky2
Copy link
Owner

graysky2 commented Mar 3, 2021

Send a PR for review if you want.

@Taijian
Copy link
Contributor Author

Taijian commented Mar 21, 2021

OK, PR has been added.

Sorry, took my some days to find the time to actually learn about the github workflow to get here...

@graysky2
Copy link
Owner

OK, continue discussion there, #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants