From 0e27f66e416a82d1898bbca727fad6f89d9bc129 Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Mon, 19 Jun 2023 11:15:25 -0400 Subject: [PATCH 1/5] chore: use node 18 (current LTS) --- Dockerfile.indexer-agent | 4 ++-- Dockerfile.indexer-cli | 4 ++-- Dockerfile.indexer-service | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Dockerfile.indexer-agent b/Dockerfile.indexer-agent index 0c2abc849..4919a35a6 100644 --- a/Dockerfile.indexer-agent +++ b/Dockerfile.indexer-agent @@ -1,7 +1,7 @@ ######################################################################## # Build image -FROM node:16.15-bullseye-slim as build +FROM node:18.16.0-slim as build ENV NODE_ENV production @@ -29,7 +29,7 @@ RUN yarn --frozen-lockfile --non-interactive --production=false ######################################################################## # Runtime image -FROM node:16.15-bullseye-slim +FROM node:18.16.0-slim ENV NODE_ENV production # When simulating large transactions, sometimes indexer-agent runs out of memory. diff --git a/Dockerfile.indexer-cli b/Dockerfile.indexer-cli index c24ab8cf2..bfe0362cf 100644 --- a/Dockerfile.indexer-cli +++ b/Dockerfile.indexer-cli @@ -1,7 +1,7 @@ ######################################################################## # Build image -FROM node:16.15-bullseye-slim as build +FROM node:18.16.0-slim as build ENV NODE_ENV production @@ -30,7 +30,7 @@ RUN yarn --frozen-lockfile --non-interactive --production=false ######################################################################## # Runtime image -FROM node:16.15-bullseye-slim +FROM node:18.16.0-slim ENV NODE_ENV production diff --git a/Dockerfile.indexer-service b/Dockerfile.indexer-service index 9722a5690..8ca79cb0c 100644 --- a/Dockerfile.indexer-service +++ b/Dockerfile.indexer-service @@ -1,7 +1,7 @@ ######################################################################## # Build image -FROM node:16.15-bullseye-slim as build +FROM node:18.16.0-slim as build ENV NODE_ENV production @@ -30,7 +30,7 @@ RUN yarn --frozen-lockfile --non-interactive --production=false ######################################################################## # Runtime image -FROM node:16.15-bullseye-slim +FROM node:18.16.0-slim ENV NODE_ENV production From 39f75624fd2e6e6fb14125cb3e077b1531e905af Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Mon, 19 Jun 2023 11:16:44 -0400 Subject: [PATCH 2/5] use node 18 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 223e00446..d83ec06d4 100644 --- a/package.json +++ b/package.json @@ -42,6 +42,6 @@ "graphql": "16.3.0" }, "engines": { - "node": ">=12.22.0" + "node": ">=18" } } From c08d98ff23bfa1900af5f6c0dd8e96daf4ddb462 Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Wed, 19 Jul 2023 15:19:25 -0500 Subject: [PATCH 3/5] use bullseye slim --- Dockerfile.indexer-agent | 4 ++-- Dockerfile.indexer-cli | 4 ++-- Dockerfile.indexer-service | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Dockerfile.indexer-agent b/Dockerfile.indexer-agent index 4919a35a6..755f3e7d1 100644 --- a/Dockerfile.indexer-agent +++ b/Dockerfile.indexer-agent @@ -1,7 +1,7 @@ ######################################################################## # Build image -FROM node:18.16.0-slim as build +FROM node:18.16.0-bullseye-slim as build ENV NODE_ENV production @@ -29,7 +29,7 @@ RUN yarn --frozen-lockfile --non-interactive --production=false ######################################################################## # Runtime image -FROM node:18.16.0-slim +FROM node:18.16.0-bullseye-slim ENV NODE_ENV production # When simulating large transactions, sometimes indexer-agent runs out of memory. diff --git a/Dockerfile.indexer-cli b/Dockerfile.indexer-cli index bfe0362cf..85627cb41 100644 --- a/Dockerfile.indexer-cli +++ b/Dockerfile.indexer-cli @@ -1,7 +1,7 @@ ######################################################################## # Build image -FROM node:18.16.0-slim as build +FROM node:18.16.0-bullseye-slim as build ENV NODE_ENV production @@ -30,7 +30,7 @@ RUN yarn --frozen-lockfile --non-interactive --production=false ######################################################################## # Runtime image -FROM node:18.16.0-slim +FROM node:18.16.0-bullseye-slim ENV NODE_ENV production diff --git a/Dockerfile.indexer-service b/Dockerfile.indexer-service index 8ca79cb0c..f5eb2c881 100644 --- a/Dockerfile.indexer-service +++ b/Dockerfile.indexer-service @@ -1,7 +1,7 @@ ######################################################################## # Build image -FROM node:18.16.0-slim as build +FROM node:18.16.0-bullseye-slim as build ENV NODE_ENV production @@ -30,7 +30,7 @@ RUN yarn --frozen-lockfile --non-interactive --production=false ######################################################################## # Runtime image -FROM node:18.16.0-slim +FROM node:18.16.0-bullseye-slim ENV NODE_ENV production From e75a272b86f7d45e7b27a76a3058bc1d52fc0248 Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Wed, 19 Jul 2023 15:20:36 -0500 Subject: [PATCH 4/5] ci: run only supported node version --- .github/workflows/ci.yml | 2 +- .github/workflows/publish-native-binaries.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bfdcb8052..934af8e7a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: build: strategy: matrix: - node-version: [14, 16, 17] + node-version: [16, 18, 20] system: - os: ubuntu-20.04 include: diff --git a/.github/workflows/publish-native-binaries.yml b/.github/workflows/publish-native-binaries.yml index 3638b7903..3307dacf8 100644 --- a/.github/workflows/publish-native-binaries.yml +++ b/.github/workflows/publish-native-binaries.yml @@ -15,7 +15,7 @@ jobs: # (https://github.com/bchr02/node-pre-gyp-github/issues/42) fail-fast: false matrix: - node_version: [14, 16, 17] + node_version: [16, 18, 20] system: - os: macos-latest target: x86_64-apple-darwin From 3904a8109fc4f8a3792e73bd3bff25e494e06080 Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Wed, 19 Jul 2023 15:27:01 -0500 Subject: [PATCH 5/5] only 18 or 20 --- .github/workflows/ci.yml | 2 +- .github/workflows/publish-native-binaries.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 934af8e7a..bd24f2f48 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: build: strategy: matrix: - node-version: [16, 18, 20] + node-version: [18, 20] system: - os: ubuntu-20.04 include: diff --git a/.github/workflows/publish-native-binaries.yml b/.github/workflows/publish-native-binaries.yml index 3307dacf8..f0e2e2342 100644 --- a/.github/workflows/publish-native-binaries.yml +++ b/.github/workflows/publish-native-binaries.yml @@ -15,7 +15,7 @@ jobs: # (https://github.com/bchr02/node-pre-gyp-github/issues/42) fail-fast: false matrix: - node_version: [16, 18, 20] + node_version: [18, 20] system: - os: macos-latest target: x86_64-apple-darwin