From 961d485e146191f5002b29db4a536bdb583e845c Mon Sep 17 00:00:00 2001 From: Gustavo Inacio Date: Mon, 27 Jan 2025 14:52:40 -0300 Subject: [PATCH] ci: fix cyclical dependency in release-please (#591) * ci: fix cyclical dependency in release-please Signed-off-by: Gustavo Inacio * chore: add comment about release-please trick Signed-off-by: Gustavo Inacio --------- Signed-off-by: Gustavo Inacio --- crates/tap-agent/Cargo.toml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/tap-agent/Cargo.toml b/crates/tap-agent/Cargo.toml index 7cb728af..c809f093 100644 --- a/crates/tap-agent/Cargo.toml +++ b/crates/tap-agent/Cargo.toml @@ -34,7 +34,7 @@ lazy_static.workspace = true thegraph-core.workspace = true clap.workspace = true tracing-subscriber.workspace = true -tonic.workspace = true +tonic.workspace = true bigdecimal = { workspace = true, features = ["serde"] } graphql_client.workspace = true @@ -49,9 +49,13 @@ ractor = { version = "0.14", features = [ tap_aggregator.workspace = true futures = { version = "0.3.30", default-features = false } bon = "3.3" -test-assets = { path = "../test-assets" , optional=true} +test-assets = { path = "../test-assets", optional = true } [dev-dependencies] +# Release-please breaks with cyclical dependencies if dev-dependencies +# import the current crate. For testing we import the current crate with the `test` +# feature enabled in order to enable test-only infrastructure within our app when running tests. +my-crate = { package = "indexer-tap-agent", path = ".", features = ["test"] } tempfile = "3.8.0" wiremock.workspace = true wiremock-grpc = "0.0.3-alpha3" @@ -59,4 +63,3 @@ test-assets = { path = "../test-assets" } test-log = { version = "0.2.12", default-features = false } bon = "3.3" rstest = "0.24.0" -indexer-tap-agent = { path = ".", features = ["test"] }