Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] graph-node allows deploying with features in manifest even when not used #5860

Open
1 of 3 tasks
shiyasmohd opened this issue Mar 1, 2025 · 0 comments · May be fixed by #5861
Open
1 of 3 tasks

[Bug] graph-node allows deploying with features in manifest even when not used #5860

shiyasmohd opened this issue Mar 1, 2025 · 0 comments · May be fixed by #5861
Assignees
@shiyasmohd
Labels
bug Something isn't working

Comments

@shiyasmohd
Copy link
Contributor

shiyasmohd commented Mar 1, 2025 •
edited
Loading

Bug report

Graph node allows deploying subgraph with features labelled in features field in subgraph manifest even though the subgraph is not using that feature.

This gives misleading info about the subgraph.

Example Deployment: QmQ52Q83ovDZDKeLtUsTE6zzbWbwhXz8CnU9iGZKPzJdB3
When checking with index-node api, it returns, this subgraph is using grafting. But actually this subgraph is not grafted.

Relevant log output

IPFS hash

QmQ52Q83ovDZDKeLtUsTE6zzbWbwhXz8CnU9iGZKPzJdB3

Subgraph name or link to explorer

No response

Some information to help us out

  • Tick this box if this bug is caused by a regression found in the latest release.
  • Tick this box if this bug is specific to the hosted service.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

OS information

None
@shiyasmohd shiyasmohd added the bug Something isn't working label Mar 1, 2025
@shiyasmohd shiyasmohd self-assigned this Mar 1, 2025
@shiyasmohd shiyasmohd changed the title [Bug] graph-node allows adding features in manifest even when not used [Bug] graph-node allows deploying with features in manifest even when not used Mar 2, 2025
@shiyasmohd shiyasmohd linked a pull request Mar 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiyasmohd shiyasmohd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add validation & tests for unused features in subgraph manifest graphprotocol/graph-node
1 participant
@shiyasmohd