From a800d09ad887257f688591ce099932da17ee6c55 Mon Sep 17 00:00:00 2001 From: Matias Date: Wed, 8 Jan 2025 15:02:55 -0300 Subject: [PATCH] fix: cleanup IPaymentCollector + TAPCollector docs --- .../horizon/contracts/interfaces/IPaymentsCollector.sol | 3 --- .../horizon/contracts/payments/collectors/TAPCollector.sol | 6 ++++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/horizon/contracts/interfaces/IPaymentsCollector.sol b/packages/horizon/contracts/interfaces/IPaymentsCollector.sol index 61854bb71..baaf37722 100644 --- a/packages/horizon/contracts/interfaces/IPaymentsCollector.sol +++ b/packages/horizon/contracts/interfaces/IPaymentsCollector.sol @@ -34,9 +34,6 @@ interface IPaymentsCollector { * @notice Initiate a payment collection through the payments protocol * @dev This function should require the caller to present some form of evidence of the payer's debt to * the receiver. The collector should validate this evidence and, if valid, collect the payment. - * Requirements: - * - The caller must be the data service the RAV was issued to - * - The signer of the RAV must be authorized to sign for the payer * * Emits a {PaymentCollected} event * diff --git a/packages/horizon/contracts/payments/collectors/TAPCollector.sol b/packages/horizon/contracts/payments/collectors/TAPCollector.sol index c8b42b87f..5b9faa932 100644 --- a/packages/horizon/contracts/payments/collectors/TAPCollector.sol +++ b/packages/horizon/contracts/payments/collectors/TAPCollector.sol @@ -124,8 +124,10 @@ contract TAPCollector is EIP712, GraphDirectory, ITAPCollector { /** * @notice Initiate a payment collection through the payments protocol * See {IGraphPayments.collect}. - * @dev Caller must be the data service the RAV was issued to. - * @dev Service provider must have an active provision with the data service to collect payments + * @dev Requirements: + * - Caller must be the data service the RAV was issued to. + * - Signer of the RAV must be authorized to sign for the payer. + * - Service provider must have an active provision with the data service to collect payments. * @notice REVERT: This function may revert if ECDSA.recover fails, check ECDSA library for details. */ function collect(IGraphPayments.PaymentTypes paymentType, bytes memory data) external override returns (uint256) {