From f5470d716fc771c674391bf9e9fdbd85d74bbebe Mon Sep 17 00:00:00 2001 From: Tommy Ludwig <8924140+shakuzen@users.noreply.github.com> Date: Wed, 20 Mar 2019 16:44:22 +0900 Subject: [PATCH] Use localhost instead of fake URIs that could go to the internet The tests right now never use this value to send an HTTP request, but in the future a test may, so proactively changes the values to something safer. See #1295 --- .../dynatrace/DynatraceMeterRegistryCompatibilityTest.java | 2 +- .../io/micrometer/dynatrace/DynatraceMeterRegistryTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryCompatibilityTest.java b/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryCompatibilityTest.java index 70ae7a2108..1c6d3bb2c8 100644 --- a/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryCompatibilityTest.java +++ b/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryCompatibilityTest.java @@ -36,7 +36,7 @@ public String apiToken() { @Override public String uri() { - return "http://doesnotmatter.com"; + return "http://localhost"; } @Override diff --git a/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryTest.java b/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryTest.java index 84dafaabb8..d285313f91 100644 --- a/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryTest.java +++ b/implementations/micrometer-registry-dynatrace/src/test/java/io/micrometer/dynatrace/DynatraceMeterRegistryTest.java @@ -251,7 +251,7 @@ public String get(String key) { @Override public String uri() { - return "http://uri"; + return "http://localhost"; } @Override