From 6ae5efd7c31e5dd9627eedc3ab93b809bfd90917 Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Mon, 11 Mar 2019 20:25:40 +0900 Subject: [PATCH] Add a test for multiple registrations of the same name of gauge (#1266) See gh-1176 --- .../core/instrument/MeterRegistryTest.java | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/MeterRegistryTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/MeterRegistryTest.java index 30a0b4ecb1..22d662f385 100644 --- a/micrometer-core/src/test/java/io/micrometer/core/instrument/MeterRegistryTest.java +++ b/micrometer-core/src/test/java/io/micrometer/core/instrument/MeterRegistryTest.java @@ -28,6 +28,12 @@ import static org.assertj.core.api.Assertions.assertThat; +/** + * Tests for {@link MeterRegistry}. + * + * @author Jon Schneider + * @author Johnny Lim + */ class MeterRegistryTest { private MeterRegistry registry = new SimpleMeterRegistry(); @@ -45,7 +51,7 @@ public MeterFilterReply accept(Meter.Id id) { } @Test - void overidingAcceptMeterFilter() { + void overridingAcceptMeterFilter() { registry.config().meterFilter(MeterFilter.accept(m -> m.getName().startsWith("jvm.important"))); registry.config().meterFilter(MeterFilter.deny(m -> m.getName().startsWith("jvm"))); @@ -97,4 +103,12 @@ void noopMetersAfterRegistryClosed() { assertThat(registry.timer("my.timer.before")).isNotInstanceOf(NoopTimer.class); assertThat(registry.timer("my.timer.after")).isInstanceOf(NoopTimer.class); } + + @Test + void gaugeRegistersGaugeOnceAndSubsequentGaugeCallsWillNotRegister() { + registry.gauge("my.gauge", 1d); + registry.gauge("my.gauge", 2d); + + assertThat(registry.get("my.gauge").gauge().value()).isEqualTo(1d); + } }