Stop Spring Bom from being applied twice

[codeconsole]

Now that the Spring Bom is parent to grails-bom.
The following code needs to be evaluated:

grails-gradle-plugin/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy

Lines 173 to 184 in 755b810

	protected void applyDefaultPlugins(Project project) {
	applySpringBootPlugin(project)
	Plugin dependencyManagementPlugin = project.plugins.findPlugin(DependencyManagementPlugin)
	if (dependencyManagementPlugin == null) {
	project.plugins.apply(DependencyManagementPlugin)
	}
	DependencyManagementExtension dme = project.extensions.findByType(DependencyManagementExtension)
	applyBomImport(dme, project)
	}

[matrei]

Yes, the org.springframework.boot:spring-boot-dependencies bom will already be added by

grails-gradle-plugin/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy

Line 189 in 755b810

project.plugins.apply(SpringBootPlugin)

I don't know if this causes a problem, and if it does, I don't see how we can prevent it, other than not applying the SpringBootPlugin, and then to duplicating what it does ourselves (leaving out the DependencyManagementPluginAction).

[codeconsole]

@matrei I am imagining we can just eliminate

     Plugin dependencyManagementPlugin = project.plugins.findPlugin(DependencyManagementPlugin) 
     if (dependencyManagementPlugin == null) { 
         project.plugins.apply(DependencyManagementPlugin) 
     } 
  
     DependencyManagementExtension dme = project.extensions.findByType(DependencyManagementExtension) 
  
     applyBomImport(dme, project) 

and just apply our bom directly.

[codeconsole]

it turns out grails-bom is being applied twice so that means the spring-bom is being applied 3 times 😮

asset-pipeline-grails-5.0.5.pom

<dependencyManagement>
<dependencies>
  <dependency>
      <groupId>org.grails</groupId>
      <artifactId>grails-bom</artifactId>
      <version>7.0.0-SNAPSHOT</version>
      <scope>import</scope>
      <type>pom</type>
  </dependency>
  <dependency>
      <groupId>org.grails</groupId>
      <artifactId>grails-bom</artifactId>
      <version>7.0.0-SNAPSHOT</version>
      <scope>import</scope>
      <type>pom</type>
  </dependency>
  <dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-dependencies</artifactId>
      <version>3.3.5</version>
      <scope>import</scope>
      <type>pom</type>
  </dependency>
</dependencies>
</dependencyManagement>