Use generic interface{} instead of string for TemplateVar.templating.… #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list.query Return type varies depending on datasource
GiedriusS
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
I double-checked and it seems OK. This seems some kind of new change. Please also update https://github.com/grafana/grafana/blob/main/docs/sources/dashboards/json-model.md if you can since it is misleading 😄
|
Thanks @GiedriusS! I'll make a PR to update that page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use generic
interface{}instead ofstringforTemplateVar.templating.list.queryThe type appears to vary depending on the
Datasourceand I could not track down a schema defining this type.Fixes #130 (the
Board.panelsunmarshal was fixed by #141)