Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh instead of bash #60

Open
ayoppa opened this issue Jun 22, 2020 · 3 comments
Open

sh instead of bash #60

ayoppa opened this issue Jun 22, 2020 · 3 comments

Comments

@ayoppa
Copy link

ayoppa commented Jun 22, 2020

Hi, I have many containers based on alpine using sh and missing bash, so I think that switching the exec command to "sh -l" would give more compatibility to this great extension.
Many thanks

Michele

@alessandrodolci
Copy link
Contributor

Hello Michele,

in case you're referring to the Open shell command, the extension already addresses such a scenario, falling back to launching /bin/sh when /bin/bash does not exist. Are you experiencing a different behavior?

@ayoppa
Copy link
Author

ayoppa commented Jul 3, 2020

It seems I was running a fork from this extension missing/cutting this feature.
Sorry from my confusing. I switched to this one and runs quickly and perfectly.
Many thanks

Michele

@alessandrodolci
Copy link
Contributor

I see, this feature has only recently been added, so it could be that someone else had implemented it in a different way. Glad you solved your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants