Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new screenshots for Denemo and Frescobaldi #20

Open
fedelibre opened this issue Mar 26, 2015 · 3 comments
Open

new screenshots for Denemo and Frescobaldi #20

fedelibre opened this issue Mar 26, 2015 · 3 comments

Comments

@fedelibre
Copy link

Following up to:
http://lists.gnu.org/archive/html/bug-lilypond/2015-03/msg00057.html

I attach here the new screenshots for Frescobaldi and Denemo.
frescobaldi
denemo

@uliska
Copy link
Contributor

uliska commented Mar 26, 2015

@fedelibre You can fork the repository, save the images to an appropriate location and create a pull request.

I suggest you do that because that way you'll be able to have the respective branch checked out and test it locally in the actual website context.
Also, this takes the burden from Phil (or whoever actually manages this repository) to think about what to do with the images.

When the images are on master in this repository you should take the next action: IIRC everybody who want to build lilypond has to manually update the lilypond-extra repository, so you should write this to lilypond-devel.
(I don't know if these images require a separate patch or if you only replace existing ones, but any necessary lilypond-patch can also be done once the images are included here).

@fedelibre
Copy link
Author

fedelibre commented Mar 26, 2015

I've just realized that the frescobaldi screenshot is not correct (highlight on music view disappeared before the screenshot). This frescobaldi bug makes things uneasy.

Ok, I think I'll add images with different names. So a lilypond patch will be needed when the pull request is accepted.

@fedelibre
Copy link
Author

I'm working on the patch to lilypond, but I get this error.
No idea of what might be wrong. I simply added the new images where the old are and renamed the links in the texinfo source.

                                                 @endgroup 
@imageFloatxxx ...@xeatspaces {#2}}^^M@end ifinfo}
                                                  @egroup 
l.261 @imageFloat{frescobaldi-small,png,right}

/home/fede/lilypond-git/Documentation/web/introduction.itexi:261:  ==> Fatal er
ror occurred, no output PDF file produced!
Transcript written on web.log.
/usr/bin/texi2dvi: pdfetex exited with bad status, quitting.

This is the patch:

diff --git a/Documentation/web/introduction.itexi b/Documentation/web/introduction.itexi
index 1c33b3b..8ef76a7 100644
--- a/Documentation/web/introduction.itexi
+++ b/Documentation/web/introduction.itexi
@@ -258,7 +258,7 @@ power. There already exist several online tools using LilyPond.

 @subheading Environment

-@imageFloat{frescobaldi-lilypond-editor-small,png,right}
+@imageFloat{frescobaldi-small,png,right}



@@ -1219,8 +1219,8 @@ In particular, don't link to:
 @subheading Front-end Applications
 @subsubheading Frescobaldi

-@imageClickable{frescobaldi-lilypond-editor-small,png,
-  (click to enlarge),frescobaldi-lilypond-editor,png,right}
+@imageClickable{frescobaldi-small,png,
+  (click to enlarge),frescobaldi,png,right}

 @sourceimage{logo-linux,,,}
 @sourceimage{logo-macosx,,,}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants