fix: Add missing type administrative_area_level_6 and administrative_area_level_7 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @wangela could you please review this? |
|
@amuramoto Do we plan to integrate the changes for the additional administrative levels? cc @gpradhan27
|
Unfortunately I'm not a maintainer on this repo anymore so I can't accept PRs. |
|
@amuramoto Do you happen to know who the maintainer is now? Is the project still supported? |
|
I believe that would be @wangela |
|
Thanks @amuramoto! @wangela Is this correct? If not, do you know if this client is still maintained by Google?
|
…area_level_7 in AddressType
|
hi @wangela any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing AddressComponentType
administrative_area_level_6andadministrative_area_level_7- the java doc comments for enum types were copied from https://developers.google.com/maps/documentation/geocoding/requests-geocoding , hope this is the correct one.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #985 🦕