Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Delete methods should fail when resources are not found #76

Open
yuryu opened this issue Jul 14, 2020 · 0 comments
Open

API: Delete methods should fail when resources are not found #76

yuryu opened this issue Jul 14, 2020 · 0 comments
Assignees
@yuryu
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
alpha2

Comments

@yuryu
Copy link
Member

yuryu commented Jul 14, 2020

What happened:
Currently DeleteStore and DeleteRecord succeed even if the specified resources are not found. This is contrary to the AIP recommendation, which states:

The Delete method should succeed if and only if a resource was present and was successfully deleted. If the resource did not exist, the method should send a NOT_FOUND error.

What you expected to happen:
DeleteStore and DeleteRecord should return the error when the specified resource is not present.
@yuryu yuryu self-assigned this Jul 14, 2020
@yuryu yuryu added bug Something isn't working good first issue Good for newcomers labels Jul 16, 2020
@yuryu yuryu added this to the alpha1 milestone Jul 16, 2020
@yuryu yuryu modified the milestones: alpha1, alpha2 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuryu yuryu

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
alpha2
Development

No branches or pull requests
1 participant
@yuryu