Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kerningRTL from .glyphs files #333

Open
rsheeter opened this issue Jun 6, 2023 · 2 comments
Open

Support kerningRTL from .glyphs files #333

rsheeter opened this issue Jun 6, 2023 · 2 comments

Comments

@rsheeter
Copy link
Contributor

rsheeter commented Jun 6, 2023

#330 (review)

@anthrotype
Copy link
Member

anthrotype commented Mar 19, 2024

So in glyphs 3, there are two kerning dictionary, kerning_ltr and kerning_rtl (whereas in UFO and glyphs < 3 there is only one kerning dict), and the user decides what pair goes where while they are kerning by toggling some button; in fontmake (glyphsLib actually) we merge the two dicts into one, and then ufo2ft kern writer spits them based on the glyph unicode properties.

fontc currently only parses the kerning_ltr and completely ignores the other kerning_rtl dictionary.
The problem, as usual, is not as simple as just merging two dictionaries... because we also need to swap left/right groups for all glyphs that are used in kerningRTL.

For reference, see
googlefonts/glyphsLib#865

@simoncozens
Copy link
Contributor

Note also that glyphsLib's implementation is incomplete (googlefonts/glyphsLib#1039).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants