From d5e611b15684492c63445555e2c808447caaa3f5 Mon Sep 17 00:00:00 2001 From: Jonas Siedentop Date: Thu, 11 Jan 2024 14:27:36 +0100 Subject: [PATCH] Enable mac tests (#77) * fix: Doc directive is missing a closing tag. * enable macos integration test in pipeline * Update supported platforms in README --- .github/workflows/test.yml | 5 ++--- README.md | 4 +--- lib/src/webcrypto/webcrypto.hmac.dart | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ab392e7e..ad551497 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -55,9 +55,8 @@ jobs: - run: flutter pub run webcrypto:setup - run: flutter test - run: flutter test --platform chrome - # TODO: Enable macos desktop when supported - #- run: flutter test integration_test/webcrypto_test.dart -d macos - # working-directory: ./example + - run: flutter test integration_test/webcrypto_test.dart -d macos + working-directory: ./example - uses: nanasess/setup-chromedriver@v2 - name: Run integration_test with chromedriver working-directory: ./example diff --git a/README.md b/README.md index 4b81fc9c..c349615f 100644 --- a/README.md +++ b/README.md @@ -12,9 +12,7 @@ browser, this package features a native implementation embedding web browser this package wraps the [`window.crypto`][window-crypto] APIs and providing the same Dart API as the native implementation. -This way, `package:webcrypto` provides the same crypto API on multiple -platforms. Initially targeting Flutter for **Android**, **iOS** and **Web**, -with other platforms following as soon as the build system allows. +This way, `package:webcrypto` provides the same crypto API on **Android**, **iOS**, **Web**, **Windows**, **Linux** and **Mac**. **Example** ```dart diff --git a/lib/src/webcrypto/webcrypto.hmac.dart b/lib/src/webcrypto/webcrypto.hmac.dart index d33bf5fd..91cb80a8 100644 --- a/lib/src/webcrypto/webcrypto.hmac.dart +++ b/lib/src/webcrypto/webcrypto.hmac.dart @@ -197,7 +197,7 @@ abstract class HmacSecretKey { /// timing attacks. To validate signatures use [verifyBytes] or [verifyStream] /// instead, these methods computes a signature and does a /// fixed-time comparison. - /// {@template} + /// {@endtemplate} Future signBytes(List data); /// Compute an HMAC signature of given [data] stream.