You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if the uuid.Invalid documentation or the (uuid.UUID).Variant() documentation mentioned this in addition to the readme, as it was confusing until I saw 3943dc5. I had read through the documentation, code, and tests before the readme of the repository, so there was a little wasted effort and confusion.
Specifically, the unit tests are a little misleading, as uuid.Parse() returns an error in the Invalid cases:
It would be nice if the
uuid.Invalid
documentation or the(uuid.UUID).Variant()
documentation mentioned this in addition to the readme, as it was confusing until I saw 3943dc5. I had read through the documentation, code, and tests before the readme of the repository, so there was a little wasted effort and confusion.Specifically, the unit tests are a little misleading, as
uuid.Parse()
returns an error in the Invalid cases:uuid/uuid_test.go
Lines 62 to 67 in 44b5fee
The variant is never checked in the unit tests in an error scenario:
uuid/uuid_test.go
Lines 99 to 101 in 44b5fee
The text was updated successfully, but these errors were encountered: