Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration not found warning when using unified gh workflow #20

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix configuration not found warning when using unified gh workflow #20

merged 1 commit into from
May 23, 2024

Conversation

shahar-h
Copy link
Contributor

Fixes #7
See #7 (comment)

@oliverchang
Copy link
Contributor

Thank you very much for the contribution! I'll defer this to @another-rex , who is still out until next week.

@another-rex another-rex self-assigned this May 22, 2024
@another-rex
Copy link
Collaborator

another-rex commented May 22, 2024 •
edited
Loading

I did test this change multiple different times in my own repo (https://github.com/another-rex/staging-osv-scanner-action/tree/fix-workflow-naming), and pointed another repo at it, but PRs still shows the error for some reason (https://github.com/another-rex/oss-fuzz-gen/pull/2/checks?check_run_id=24492679877).

(This run is on this PR branch: https://github.com/another-rex/oss-fuzz-gen/pull/4/checks?check_run_id=25255207554, still shows the error.)

I think it originates from the scheduled scan being skipped, which changing the name won't fix, but I'm not sure about this.

@shahar-h
Copy link
Contributor Author

Tested again on my repo and it works:
shahar-h/gateway#19
https://github.com/shahar-h/gateway/pull/19/checks?check_run_id=25260222254

I noticed that your both PR branches are not rebased against main branch. Can you try to rebase them or open a new PR?

another-rex
another-rex approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can't replicate this, but is a small change so let's merge it and see if it works :)

@another-rex another-rex merged commit 8d8993e into google:main May 23, 2024
4 checks passed
@shahar-h shahar-h deleted the patch-1 branch May 23, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@another-rex another-rex another-rex approved these changes

Assignees

@another-rex another-rex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configuration not found warning when using unified gh workflow
3 participants
@shahar-h @oliverchang @another-rex