Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit boostrap tools use in builds #124

Open
msuozzo opened this issue Oct 14, 2024 · 0 comments
Open

Revisit boostrap tools use in builds #124

msuozzo opened this issue Oct 14, 2024 · 0 comments

Comments

@msuozzo
Copy link
Member

msuozzo commented Oct 14, 2024

Currently, OSS Rebuild build tools are downloaded from mutable GCS addresses in the google-rebuild-bootstrap-tools bucket.

Ideally, we'd like to avoid incorporating prebuilt binaries like this, especially as subsequent changes to these build binaries may break the builds.

To bridge the gap, I see a few options:

  1. Versioning GCS addresses
    • Pro: Locks the tool versions to immutable addresses
    • Con: A bit more complex to version
    • Con: A bit more verbose
  2. Create GitHub releases for tool builds that builds could download
  3. Inline build tool builds with go run
    • Pro: No intermediate builds
    • Con: Meaningful increase in build cost+latency (TODO: quantify this)
      • Although the toolchain installation cost would be amortized across the full set of binaries.
      • Could potentially cache these but, as always, there be 🐉🐉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant